52

6

is it possible to create a code review when using the kiln file view?

go to a file, example, http://fogbugz.YourSite.com/kiln/Repo/Repositories/WebSites/BLAH/Files/src/Project/blah.cs

see an issue, create code review/case from it...

(i'm using kiln 2.0)

Fog Creek Case FC1961679

flag

1 Answer

6

It's not currently possible to create a code review of a file; only a changeset. We're thinking about expanding the ways you can create reviews in future versions of Kiln, but for version 2.0, you unfortunately cannot do that.

link|flag
ok thanks. it came up after a code review from a third party tool. we're new to kiln, so i'd have to use the initial code import as the changeset to review. the initial import was some versions ago and it seemed strange to do a code review somewhat after the fact when the issue is still in the tip. – bluevoodoo1 Sep 17 2010 at 17:55
Since Code Reviews are one of the main things Kiln adds to Hg, making them as easy as possible to raise seems like a wise idea to me, and it follows very nicely with the FogBugz ideal of keeping the barrier to entry (ie. opening a new review) as low as possible to encourage using code reviews. It's better to have too many reviews than not enough. – cdeszaq Nov 9 2010 at 14:04
1 
 I usually come into the code review process at a much later stage to apply my 25+ years of "old man" knowledge and experience to what is written. So, rather than printing out the source code on paper, marking it up with a red pen, and then passing it back to the developer--I (and our team) are wanting to review the current state of the source code as a single file (w/o change sets). Atlassian's Crucible allowed us to do that. I guess I'm back to the paper and red pen method. Argh... – ChrisM Jul 8 2011 at 10:07
Put me in the same boat as ChrisM. Just migrated from JiraStudio, missing this already. – DamianH Jul 27 2011 at 19:52
1 
 You've convinced us; it'll just be a bit before we get the change landed. Hang in there. :) – Benjamin Pollack♦ Jul 27 2011 at 20:23
show 9 more comments

Your Answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.