0

I opened a review with a few changesets. The reviewer asked me to rename some files to fit with the coding standards we have.

I use mercurial rename to rename it properly (hg mv) so mercurial is aware of the rename and commit it. TortoiseHG displays: fileY.sql (was renamed from fileX.sql).

After that I commited a few syntax fixes to the files.

Add the changesets to the review. Now under the files view of the review the old files still exist. Kiln reviews have no awareness of file renames!

What this means is other reviewers will be reviewing the wrong files. We end up just creating a new review with half the changesets. This is just totally useless and costs people their time.

It's confusing when file renames are involved... do I really have to patch all the commits into another branch?!

Perhaps you can put a note on the fileY label saying it was renamed from fileX.

Kiln Version 2.8.11.0

flag

2 Answers

1

Hi Dilbo! Thanks for the bug report. We'll get this fixed up for a future release.

link|flag
0

Any word on this being implemented?

link|flag
It does seem to work now. But they've removed the ability to close reviews. It's really messed up my workflow. FogCreek just don't get how people use their products. :( – Dilbo Sep 27 at 23:19

Your Answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.